[patch] staging: comedi: cleanup comedi_recognize()

walter harms wharms at bfs.de
Wed Jun 6 09:45:43 UTC 2012



Am 06.06.2012 11:28, schrieb Ian Abbott:
> On 2012-06-05 12:01, Dan Carpenter wrote:
>> On Tue, Jun 05, 2012 at 12:06:10PM +0200, walter harms wrote:
>>> Hi all,
>>> the patch is fine with me but i have a few basic questions:
>>>
>>> Why the (void  *) at all ? it returns a name what is a const char *.
>>>
>>
>> We're really returning a pointer to a private struct, it's just that
>> the first element on the struct always has to be a pointer to char *.
> 
> To be pedantic, it's really returning a pointer to some member of type
> 'const char *' within a private struct.  To make life easier for
> themselves, those drivers make that the first member of the private
> struct so a void pointer to the member is also a void pointer to the
> struct.
> 

I do not like it. It is confusing.
Are these struct comedi_driver *driv of different size every time ?
or why is it not possible to return simply driv[i] ?

re,
 wh



More information about the devel mailing list