[PATCH 1/2] staging: Android: Fix some checkpatch warnings

[Sachin Kamat]

On 05/06/2012, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Tue, Jun 05, 2012 at 03:10:29PM +0530, Sachin Kamat wrote:
>> On 05/06/2012, Dan Carpenter <dan.carpenter at oracle.com> wrote:
>> > On Tue, Jun 05, 2012 at 01:56:43PM +0530, Sachin Kamat wrote:
>> >> Warnings reported by checkpatch.pl have been fixed.
>> >>
>> >
>> > If you use the pr_fmt macro then you can remove the "ashmem: "
>> > prefixes probably.
>>
>> pr_fmt macros do not append the module/function names to the fmt string.
>> Hence addition of module names (like ashmem) adds to readability.
>>
>
> I'm confused what you are saying here.  Adding the module name is
> the whole point of the pr_fmt macro.  You put it at the top of the
> file before the includes like this:
>
> #define pr_fmt(fmt) "ashmem: " fmt

Sorry, I totally misunderstood your previous e-mail.
Yes you are right, individual tags could be replaced with pr_fmt macro.
Thanks for pointing it out.

>
> regards,
> dan carpenter
>


-- 
With warm regards,
Sachin