[PATCH] staging: comedi: remove private header comedi_pci.h

gregkh at linuxfoundation.org gregkh at linuxfoundation.org
Tue Jun 5 03:23:14 UTC 2012


On Tue, May 22, 2012 at 11:06:24AM +0100, Ian Abbott wrote:
> On 2012-05-22 01:12, H Hartley Sweeten wrote:
> >Remove the private header, comedi_pci.h, by moving the two
> >helper functions into divers.c and providing the prototypes
> >in comedidev.h.
> >
> >This allows the comedi_pci_enable/disable helper functions
> >to be shared instead of having an inline version in every
> >comedi pci driver.
> 
> I'm wondering if these functions should be EXPORT_SYMBOL() or
> EXPORT_SYMBOL_GPL() since they were originally inline functions.
> 
> Opinions?

Are there any known out-of-tree comedi drivers?  I say leave this as-is
and see if anyone complains :)

thanks,

greg k-h



More information about the devel mailing list