[PATCH 22/90] staging: comedi: adv_pci_dio: remove CheckAndAllocCard()

Ian Abbott abbotti at mev.co.uk
Thu Jul 19 09:50:55 UTC 2012


On 2012-07-19 02:34, H Hartley Sweeten wrote:
> This driver creates a linked list of all the pci devices in
> the system while it's looking for a match. It's only use is
> to determine if a device is "free" to use. The pci_is_enabled()
> helper can give us the same information. Use that instead and
> remove the linked list.

As mentioned in my replies to your patches to adv_pci1723 and 
adv_pci1710, pci_is_enabled() might not be sufficient.  I think it's 
better just to take out the free/in-use test.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-





More information about the devel mailing list