[PATCH 3/8] pstore: Add persistent function tracing
Anton Vorontsov
anton.vorontsov at linaro.org
Tue Jul 17 22:06:26 UTC 2012
On Tue, Jul 17, 2012 at 05:38:22PM -0400, Steven Rostedt wrote:
[...]
> > > BTW, can any of the called functions go into module code that can be
> > > removed? If so, then this is not safe at all. Normal function tracing
> > > can not be synced in a preemptible kernel.
> >
> > Um. Yes, psinfo->write_buf() might be in the module. Nice catch.
Oh, actually, while write_buf() can technically be in a removable module,
the RAM backend can't be removed once loaded. So it is not a real issue.
But I'll implement your idea anyway, it seems a bit cleaner and safer,
plus if we ever want to make persistent_ram backend removable, we won't
need to bother w/ this particular issue.
Thanks!
--
Anton Vorontsov
Email: cbouatmailru at gmail.com
More information about the devel
mailing list