[PATCH 00/30] staging: comedi: move 'struct pci_dev *' into comedi_device

Ian Abbott abbotti at mev.co.uk
Thu Jul 12 08:55:30 UTC 2012


On 2012/07/11 10:47 PM, H Hartley Sweeten wrote:
> All the comedi pci drivers have a struct pci_dev * in their private
> data to hold the pointer to the pci device. Some of the drivers only
> have private data because of this pointer.
> 
> Move the variable into the comedi_device struct and remove the private
> data for the drivers that no longer need it.

I suppose at a later date we could turn that into a union with a short
name like u (so comedidev->pcidev would become something like
comedidev->u.pcidev), which would allow us to stick a 'struct
usb_interface *' or some other hardware device wrapper struct pointer in
the same hole.  (Maybe 'h' for 'hardware' would be better than 'u'.)

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>             )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587              )=-



More information about the devel mailing list