[PATCH 2/3] staging/slicoss: disable pci device at remove
Greg Kroah-Hartman
gregkh at linuxfoundation.org
Mon Jul 9 20:06:04 UTC 2012
On Mon, Jul 09, 2012 at 11:04:19PM +0530, Devendra Naga wrote:
> at probe we enabled the device, and we should disable it at remove.
>
> Signed-off-by: Devendra Naga <devendra.aaru at gmail.com>
> ---
> drivers/staging/slicoss/slicoss.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/slicoss/slicoss.c b/drivers/staging/slicoss/slicoss.c
> index a511a2b..5bd3825 100644
> --- a/drivers/staging/slicoss/slicoss.c
> +++ b/drivers/staging/slicoss/slicoss.c
> @@ -3234,6 +3234,7 @@ static void __devexit slic_entry_remove(struct pci_dev *pcidev)
> }
> free_netdev(dev);
> pci_release_regions(pcidev);
> + pci_disable_device(pcidev);
No, you really shouldn't do this, see the many times this has come up on
the linux-kernel mailing list for why.
thanks,
greg k-h
More information about the devel
mailing list