[PATCH 0/6] staging: vt6655: Cleanup in usage of macros
Marcos Souza
marcos.souza.org at gmail.com
Mon Jul 9 09:19:22 UTC 2012
2012/7/9 Joe Perches <joe at perches.com>
>
> On Sun, 2012-07-08 at 23:51 -0300, Marcos Paulo de Souza wrote:
> > Hi kernel guys!
> >
> > This patchset aims to clean all unused and commented macros.
> >
> > For this challenge, forgotten-macros tool helped us.
>
> Perhaps there may be false positives in your code.
Not in this case. After each changes in a file, I compiled all driver again.
> Many times, macros like the below are used:
> #define SUBSYSTEM_PREFIX_FOO 1
> #define SUBSYSTEM_PREFIX_BAR 2
> #define SUBSYSTEM_PREFIX_BAZ 3
>
> #define USE_TYPE(type) SUBSYSTEM_PREFIX_##type
>
> It doesn't seem your code knows that style.
True! The tool is under development. A more robust method will be
implemented, but for now, the tool can find the most "easy" dead macros.
> Also, the tool might be more flexible if it was
> written using perl or python.
>
Yeah, I believe it's true!
Thanks for the comments!
But, for the changes, do I have your ack?
Thanks Joe!
--
Att,
Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
More information about the devel
mailing list