[PATCH v2 4/8] staging: tidspbridge: silence the compiler

Víctor M. Jáquez L. vjaquez at igalia.com
Tue Jan 31 11:19:52 UTC 2012

On Tue, Jan 31, 2012 at 11:05:43AM +0300, Dan Carpenter wrote:
> On Tue, Jan 31, 2012 at 12:12:20AM +0100, Víctor Manuel Jáquez Leal wrote:
> > Silence the warning when compiling drv_interface.c
> > 
> > Signed-off-by: Víctor Manuel Jáquez Leal <vjaquez at igalia.com>
> What does the compiler warn about here?  Normally you would cut and
> paste the warning into the commit message.  But at least give us a
> hint.
> You could also reformat that printk so the message is on one line.
> 	dev_dbg(bridge,
> 	        "%s: vm filp %p offset %x start %lx end %lx page_prot %ulx flags %lx\n",
> 		__func__, filp, offset, vma->vm_start, vma->vm_end,
> 		vma->vm_page_prot, vma->vm_flags);

Ok. I'll do it.

I have a doubt about the process in this case: if this is the only
modification request, should I resend all the patch set, or just this one?



> regards,
> dan carpenter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120131/0f49639f/attachment.asc>

More information about the devel mailing list