[PATCH 1/2] Staging; bcm/CmHost.c: Style cleanup

Dan Carpenter dan.carpenter at oracle.com
Wed Jan 25 06:26:58 UTC 2012


This is probably going to need to be redone on top of the other bcm
cleanup patches anyway.

On Tue, Jan 24, 2012 at 11:46:31PM +0100, Jesper Juhl wrote:
> +		pstClassifierEntry->ucDestPortRangeLength
> +			= psfCSType->cCPacketClassificationRule.u8ProtocolDestPortRangeLength/4;

Put the equals on the first line when you break something up like
this. Also the real fix here is to choose shorter and better names
than "cCPacketClassificationRule.u8ProtocolDestPortRangeLength".

If you're breaking up a condition normally the && or || go on the
first line as well.
	if (foo &&
	    bar &&
	    baz) { ...

Although that's not in CodingStyle so it's not a "redo the patch"
situation.

regards,
dan carpenter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120125/813d6e47/attachment.asc>


More information about the devel mailing list