[PATCH 5/5] Staging: android: Add KERN_ facility level in printk () in pmem.c

Dima Zavin dima at android.com
Mon Jan 23 17:22:27 UTC 2012


We really should just get rid of pmem.c altogether. We will remove it
from our android common tree too. We don't actually use it anymore in
any of our products. There are some legacy users of it, like Qualcomm,
but I'm sure they have a bunch of patches on top of it and thus are
maintaining it separately anyway.

--Dima

On Fri, Jan 20, 2012 at 7:24 PM, Kashyap Gada <gada.kashyap at gmail.com> wrote:
> diff --git a/drivers/staging/android/pmem.c b/drivers/staging/android/pmem.c
> index 65ba61a..c589c0c 100644
> --- a/drivers/staging/android/pmem.c
> +++ b/drivers/staging/android/pmem.c
> @@ -831,7 +831,7 @@ static int pmem_connect(unsigned long connect, struct file *file)
>        src_file = fget_light(connect, &put_needed);
>        DLOG("connect %p to %p\n", file, src_file);
>        if (!src_file) {
> -               printk("pmem: src file not found!\n");
> +               printk(KERN_ERR "pmem: src file not found!\n");
>                ret = -EINVAL;
>                goto err_no_file;
>        }
> @@ -934,7 +934,7 @@ int pmem_remap(struct pmem_region *region, struct file *file,
>        if (unlikely(!PMEM_IS_PAGE_ALIGNED(region->offset) ||
>                 !PMEM_IS_PAGE_ALIGNED(region->len))) {
>  #if PMEM_DEBUG
> -               printk("pmem: request for unaligned pmem suballocation "
> +               printk(KERN_DEBUG "pmem: request for unaligned pmem suballocation "
>                       "%lx %lx\n", region->offset, region->len);
>  #endif
>                return -EINVAL;
> --
> 1.7.5.4
>



More information about the devel mailing list