[PATCH 1/6] staging:android_pmem.h: Fixes the space and other formating issues pointed out by checkpatch.pl

Andy Whitcroft apw at canonical.com
Fri Jan 20 11:12:55 UTC 2012


On Wed, Jan 18, 2012 at 6:54 PM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Wed, Jan 18, 2012 at 11:38:34PM +0530, Pradheep Shrinivasan wrote:
>>> > > -#define PMEM_IOCTL_MAGIC 'p'
>> > > +#define PMEM_IOCTL_MAGIC ('p')
>> >
>> > You don't need parenthesis here.  Did checkpatch really complain
>> > about this?
>>
>> Yes the check patch does complain about the parenthesis.
>>
>> pradheep at ubuntu:~/linux-next/
>> linux-next/drivers/staging/android$ checkpatch android_pmem.h
>> android_pmem.h:10: ERROR: trailing whitespace
>> android_pmem.h:19: ERROR: Macros with complex values should be enclosed in
>> parenthesis
>
> That seems like a bug in checkpatch.pl.  It's hard to imagine less
> complex macro than:  #define PMEM_IOCTL_MAGIC 'p'

I can think of no way in which an unprotected character is different
to an unprotected integer constant.  So ...

Does the version here work better for you:

    http://people.canonical.com/~apw/checkpatch/checkpatch-next.pl

-apw



More information about the devel mailing list