[PATCH 4/9] staging: nvec: ps2: add some more debug functions

Dan Carpenter dan.carpenter at oracle.com
Tue Jan 10 11:35:52 UTC 2012


On Mon, Dec 26, 2011 at 05:57:35PM +0100, Julian Andres Klode wrote:
>  	case NVEC_PS2:
> -		if (msg[2] == 1)
> +		if (msg[2] == 1) {
>  			for (i = 0; i < (msg[1] - 2); i++)
>  				serio_interrupt(ps2_dev.ser_dev, msg[i + 4], 0);
> -		else if (msg[1] != 2) {	/* !ack */
> -			print_hex_dump(KERN_WARNING, "unhandled mouse event: ",
> -				DUMP_PREFIX_NONE, 16, 1,
> -				msg, msg[1] + 2, true);
> +			NVEC_PHD("ps/2 mouse reply: ", &msg[4], msg[1] - 2);
>  		}
>  
> +		else if (msg[1] != 2) /* !ack */
> +			NVEC_PHD("unhandled mouse event: ", msg, msg[1] + 2);

Kernel style is that the else goes on the same line as the close
brace and if one side of the if else statement gets braces then they
both do.
	if (foo) {
		frob();
		frob();
		frob();
	} else {
		frob_once();
	}

regards,
dan carpenter

>  		return NOTIFY_STOP;
>  	}
>  
> -- 
> 1.7.7.3
> 
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120110/12c04f74/attachment.asc>


More information about the devel mailing list