[PATCH 1/6] Staging: bcm: Fix coding style issues in CmHost.c
Kevin McKinney
klmckinney1 at gmail.com
Tue Jan 3 14:14:02 UTC 2012
On Tue, Jan 3, 2012 at 1:14 AM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Mon, Jan 02, 2012 at 11:17:16PM -0500, Kevin McKinney wrote:
>> case eDeletePHSRule:
>> {
>> - BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL,"PHS DSC Action = Delete PHS Rule \n");
>> + BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "PHS DSC Action = Delete PHS Rule\n");
>>
>> - if(psfCSType->cPhsRule.u8PHSI)
>> - {
>> - PhsDeletePHSRule(
>> - &Adapter->stBCMPhsContext,
>> - uVCID,
>> - psfCSType->cCPacketClassificationRule.u8AssociatedPHSI);
>> - }
>> + if (psfCSType->cPhsRule.u8PHSI)
>> + PhsDeletePHSRule(&Adapter->stBCMPhsContext, uVCID, psfCSType->cCPacketClassificationRule.u8AssociatedPHSI);
>> else
>> - {
>> - //BCM_DEBUG_PRINT(CONN_MSG,("Error CPHSRule.PHSI is ZERO \n"));
>> - }
>> + /* BCM_DEBUG_PRINT(CONN_MSG,("Error CPHSRule.PHSI is ZERO\n")); */
>> +
>> break;
>
>
> This is broken. You removed the empty curly braces so now onle the
> else statement breaks. You have to remove the else statement as
> well.
>
Okay - I will fix this and resubmit all six patches. Thanks for catching this.
Thanks,
Kevin
More information about the devel
mailing list