[PATCH 1/6] Staging: bcm: Fix coding style issues in CmHost.c

Dan Carpenter dan.carpenter at oracle.com
Tue Jan 3 07:55:41 UTC 2012


On Mon, Jan 02, 2012 at 11:17:16PM -0500, Kevin McKinney wrote:
> -			else
> -			{
> -				//This Classifier Already Exists and it is invalid to Add Classifier with existing PCRI
> -				BCM_DEBUG_PRINT( Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL,"CopyToAdapter : Error The Specified Classifier Already Exists \
> -						and attempted To Add Classifier with Same PCRI : 0x%x\n", u16PacketClassificationRuleIndex);
> +				/* Copy the Classifier Rule for this service flow into our Classifier table maintained per SF. */
> +				CopyClassifierRuleToSF(Adapter, psfCSType, uiSearchRuleIndex, nClassifierIndex);
> +			} else {
> +				/* This Classifier Already Exists and it is invalid to Add Classifier with existing PCRI */
> +				BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL,
> +						"CopyToAdapter: Error The Specified Classifier Already Exists and attempted To Add Classifier with Same PCRI : 0x%x\n",
> +						u16PacketClassificationRuleIndex);
>  			}

Btw, I don't know if you noticed, but this is a small bugfix.  The
original code but bogus tabs into the printk.

Was there some automated tool to find these?

regards,
dan carpenter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120103/5e0f20ae/attachment.asc>


More information about the devel mailing list