[PATCH 1/6] Staging: bcm: Fix coding style issues in CmHost.c

Dan Carpenter dan.carpenter at oracle.com
Tue Jan 3 06:14:48 UTC 2012


On Mon, Jan 02, 2012 at 11:17:16PM -0500, Kevin McKinney wrote:
>  		case eDeletePHSRule:
>  		{
> -			BCM_DEBUG_PRINT(Adapter,DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL,"PHS DSC Action = Delete PHS Rule \n");
> +			BCM_DEBUG_PRINT(Adapter, DBG_TYPE_OTHERS, CONN_MSG, DBG_LVL_ALL, "PHS DSC Action = Delete PHS Rule\n");
>  
> -			if(psfCSType->cPhsRule.u8PHSI)
> -			{
> -				PhsDeletePHSRule(
> -					&Adapter->stBCMPhsContext,
> -					uVCID,
> -					psfCSType->cCPacketClassificationRule.u8AssociatedPHSI);
> -			}
> +			if (psfCSType->cPhsRule.u8PHSI)
> +				PhsDeletePHSRule(&Adapter->stBCMPhsContext, uVCID, psfCSType->cCPacketClassificationRule.u8AssociatedPHSI);
>  			else
> -			{
> -				//BCM_DEBUG_PRINT(CONN_MSG,("Error CPHSRule.PHSI is ZERO \n"));
> -			}
> +				/* BCM_DEBUG_PRINT(CONN_MSG,("Error CPHSRule.PHSI is ZERO\n")); */
> +
>  			break;


This is broken.  You removed the empty curly braces so now onle the
else statement breaks.  You have to remove the else statement as
well.

regards,
dan carpenter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120103/e82d8ff0/attachment.asc>


More information about the devel mailing list