[PATCH 1/2] staging: zcache: fix length type mismatch

Dan Carpenter dan.carpenter at oracle.com
Wed Feb 29 06:22:20 UTC 2012


On Tue, Feb 28, 2012 at 04:01:37PM -0600, Seth Jennings wrote:
> This fixes a type mismatch in the compression code where
> a size_t pointer was cast to a unsigned int pointer.  On
> little endian archs, there is no issue.  However on big
> endian archs, the value is incorrect, taking the high
> order bits and truncating the lower order bits.

I would think this would be a problem on any 64bit machine not just
big endian ones.  Since clen is half uninitialized we would likely
hit the clen > zbud_max_buddy_size() test.

Anyway the patch is right.

regards,
dan carpenter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120229/e286d36a/attachment.asc>


More information about the devel mailing list