[PATCH 5/9] staging: easycap: Push video registration to easycap_register_video()

Ezequiel García elezegarcia at gmail.com
Fri Feb 24 18:58:39 UTC 2012


Hi Dan,

On Fri, Feb 24, 2012 at 3:39 PM, Dan Carpenter <dan.carpenter at oracle.com> wrote:
> On Fri, Feb 24, 2012 at 12:24:18PM -0300, Ezequiel Garcia wrote:
>> +             rc = easycap_register_video(peasycap);
>> +             if (rc < 0)
>>                       return -ENODEV;
>
> Don't resend.  These are beautiful patches you are sending and I
> wouldn't want to slow you down.  But it would have been better to
> return rc here.

Ok, I'll do that in the future. Thanks for the feedback, and feel free
to keep it coming :)
Thanks for taking the time to review.

I have to say I'm thrilled with having time (and knowledge) to work on
the linux kernel.
It was 12 years ago when I first installed a linux distro and I had no
idea what to do with it
back then! ;)



More information about the devel mailing list