[PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

Ezequiel García elezegarcia at gmail.com
Mon Feb 20 23:03:15 UTC 2012


El día 20 de febrero de 2012 12:24, Dan Carpenter
<dan.carpenter at oracle.com> escribió:
> So how it works is that Mauro (who is not CC'd) pulls patches from
>the list.  Mauro maintains everything in drivers/staging/media/.
>If he likes the patches he merges them.  Generally they get merged
> in the order they were submitted.

Mmm, looks like I got it all wrong: Easycap now belongs to
staging/media. So easycap patches should be sent to linux-media list
and using Mauro's tree (linux-media). I missed the moving patch.
Please correct me if I'm wrong.

>
> Also Tomas Winkler has been working on this driver so you'd have to
> coordinate with him as well.  If he sends a patch, then your patch
> has to apply on top of his.  CC him on any patches you send for
> easycap.

All these information is great help for me. Thanks.

As I already stated, I know the driver is buggy (it panicked to me a
couple of times) and that there is plenty of room for improvement
(ioctls is old styled, usb_probe() is maybe allocating buffers too
soon).
However, being a newbie, I'm still trying different modifications, see
how they fit, how they work, etc. Besides, cleaning a bit the style
and splitting functions is helping me a lot understand the code.
So that's what I'm working on right now.

I'm still unsure whether these patches help the maintainers in any
way, but I didn't want to keep on working locally and take my branch
too far from mainstream.

Thanks everyone for your time,
Ezequiel.



More information about the devel mailing list