[staging-next] staging/mei: mei-amt-version - make all function static

Dan Carpenter dan.carpenter at oracle.com
Mon Feb 20 10:56:10 UTC 2012


On Mon, Feb 20, 2012 at 11:54:46AM +0200, Tomas Winkler wrote:
> since this is a single file example make also API-like function
> static and used to remove compilation warnings.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler at intel.com>

[ snip ]

> @@ -455,6 +455,8 @@ int main(int argc, char **argv)
>  
>  	status = amt_get_code_versions(&acmd, &ver);
>  
> +	amt_host_if_deinit(&acmd);
> +

The changelog sucks.  What is the effect of this change?  Why don't
we just delete the function instead?

regards,
dan carpenter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120220/40eb602a/attachment.asc>


More information about the devel mailing list