[PATCH 1/2] staging: easycap: Clean comment style in easycap_usb_probe()

Dan Carpenter dan.carpenter at oracle.com
Mon Feb 20 06:24:55 UTC 2012


On Sun, Feb 19, 2012 at 08:00:27PM -0300, Ezequiel García wrote:
> Hi,
> 
> El día 19 de febrero de 2012 17:49, Dan Carpenter
> <dan.carpenter at oracle.com> escribió:
> >
> > You've dropped Greg and driver devel from the CC list.  It's all up
> > to Greg whether to merge your patch or not, so it doesn't matter
> > what I say if he isn't on the CC list.
> 
> Sorry for that. I've just forwarded my previous mail to driver devel list.
> 
> >
> > None of the multi-line commits were totally right according to
> > CodingStyle so it's probably best to just redo the patch and send
> > a v2.
> 
> What do you mean with "not totally right".
> Just point out what's wrong and I'll be glad to fix it :)
> 

The preferred style for long (multi-line) comments is:

        /*
         * This is the preferred style for multi-line
         * comments in the Linux kernel source code.
         * Please use it consistently.
         *
         * Description:  A column of asterisks on the left side,
         * with beginning and ending almost-blank lines.
         */

From CodingStyle.

regards,
dan carpenter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120220/aa5d8ee4/attachment.asc>


More information about the devel mailing list