[PATCH] bcm: move DRIVER_HALT into enum LedEvents
Kevin McKinney
klmckinney1 at gmail.com
Tue Feb 14 15:41:15 UTC 2012
Hi Danny,
On Tue, Feb 14, 2012 at 9:48 AM, Danny Kukawka <danny.kukawka at bisect.de> wrote:
> Move DRIVER_HALT into enum LedEvents to fix:
> drivers/staging/bcm/led_control.c: In function ‘LEDControlThread’:
> drivers/staging/bcm/led_control.c:817:3: warning: case value ‘255’
> not in enumerated type ‘LedEventInfo_t’ [-Wswitch]
>
> Signed-off-by: Danny Kukawka <danny.kukawka at bisect.de>
> ---
> drivers/staging/bcm/led_control.h | 6 ++----
> 1 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/bcm/led_control.h b/drivers/staging/bcm/led_control.h
> index 0711ac2..57c8c45 100644
> --- a/drivers/staging/bcm/led_control.h
> +++ b/drivers/staging/bcm/led_control.h
> @@ -63,12 +63,10 @@ typedef enum LedEvents {
> IDLEMODE_CONTINUE = 0x40,
> IDLEMODE_EXIT = 0x80,
> LED_THREAD_INACTIVE = 0x100, //Makes the LED thread Inactivce. It wil be equivallent to putting the thread on hold.
> - LED_THREAD_ACTIVE = 0x200 //Makes the LED Thread Active back.
> + LED_THREAD_ACTIVE = 0x200, /*Makes the LED Thread Active back*/
> + DRIVER_HALT = 0xff
> } LedEventInfo_t; /*Enumerated values of different driver states*/
>
> -#define DRIVER_HALT 0xff
> -
> -
A patch to fix this issue has already been submitted and applied.
Thanks,
Kevin
More information about the devel
mailing list