Staging: bcm: Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()

Greg KH gregkh at linuxfoundation.org
Fri Feb 10 18:00:37 UTC 2012


On Thu, Feb 09, 2012 at 11:33:25PM +0100, Jesper Juhl wrote:
> From: Jesper Juhl <jj at codesealer.com>
> 
> We allocate memory for 'pstAddIndication' with kmalloc() in
> drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> neglect to free it on a number of exit paths from that function.
> 
> This could probably be resolved cleaner/nicer, but this file needs a
> serious overhaul in any case, so I opted for just fixing the problem
> as directly as I could and then we can clean it up generally
> later... This at least makes it stop bleeding..
> 
> Signed-off-by: Jesper Juhl <jj at codesealer.com>

Odd, didn't I already apply this patch?

confused,

greg k-h



More information about the devel mailing list