[PATCH 2/2] Staging; Don't leak 'pstAddIndication' in CmHost.c::StoreCmControlResponseMessage()

Greg KH gregkh at linuxfoundation.org
Thu Feb 9 17:52:17 UTC 2012


On Tue, Jan 24, 2012 at 11:47:27PM +0100, Jesper Juhl wrote:
> We allocate memory for 'pstAddIndication' with kmalloc() in
> drivers/staging/bcm/CmHost.c::StoreCmControlResponseMessage() and then
> neglect to free it on a number of exit paths from that function.
> 
> This could probably be resolved cleaner/nicer, but this file needs a
> serious overhaul in any case, so I opted for just fixing the problem
> as directly as I could and then we can clean it up generally
> later... This at least makes it stop bleeding..
> 
> Signed-off-by: Jesper Juhl <jj at chaosbits.net>
> ---
>  drivers/staging/bcm/CmHost.c |   27 ++++++++++++++++++++-------
>  1 files changed, 20 insertions(+), 7 deletions(-)


This patch no longer applies, care to redo it against the latest
linux-next tree?

thanks,

greg k-h



More information about the devel mailing list