[PULL REQUEST] staging: bcm: logging cleanups

Joe Perches joe at perches.com
Thu Feb 9 03:46:16 UTC 2012


On Wed, 2012-02-08 at 18:11 -0800, Joe Perches wrote:
> On Wed, 2012-02-08 at 17:38 -0800, Greg KH wrote:
> > On Wed, Feb 08, 2012 at 05:33:14PM -0800, Joe Perches wrote:
> > > On Wed, 2012-02-08 at 17:21 -0800, Greg KH wrote:
> > > > On Mon, Jan 09, 2012 at 10:06:51AM -0800, Joe Perches wrote:
> > > > > Standardize and neaten the logging messages.
> > > > These patches don't apply, and I'm guessing your other ones will not as
> > > > well.
> > > > Please resend all of the bcm patches you want me to apply, I've purged
> > > > all of yours from my queue now.
> > > Why don't they apply?
> > > Did you just apply Johannes patches
> > > or other BCM patches?
> > Other ones.
> > > He and I both asked you not to.
> > I didn't apply either of yours.
> 
> I was wrong, it was Kevin McKinnon's patches
> you applied, and he was the one that said
> he'd redo his patches.
> 
> I think I should send reverts and
> my original patch set once again.

OK, I've done the reverts against your tree,
and applied my patches again.

The following changes since commit 2d9ebe77b7665a431a9816eff3eb588e05176dfa:

  Staging: bcm: Use memdup_user rather than duplicating its implementation (2012-02-08 17:22:16 -0800)

are available in the git repository at:
  git://repo.or.cz/linux-2.6/trivial-mods.git 20120207_bcm

Joe Perches (47):
      Revert "Staging: bcm: Use memdup_user rather than duplicating its implementation"
      Revert "Staging: bcm: Alter name, datatype, and default value of iterator variables."
      Revert "Staging: bcm: Replace variables and function outputs defined as INT with int."
      Revert "Staging: bcm: Remove assignment from if statement and reverse if logic for readability."
      Revert "Staging: bcm: Remove typedef from CmHost.c and use enum."
      Revert "Staging: bcm: Replace dated variable __FUNCTION__."
      Revert "Staging: bcm: Fix coding style issues in CmHost.c"
      Revert "Staging: bcm: Fix an integer overflow in IOCTL_BCM_NVM_READ/WRITE"
      staging: bcm: Convert BCM_DEBUG_PRINT(..., DBG_TYPE_PRINTK to pr_info
      staging: bcm: Add DBG_TYPE_CMHOST
      staging: bcm: Convert BCM_DEBUG_PRINT to bcm_dbg
      staging: bcm: Use pr_debug in bcm_dbg
      staging: bcm: Use pr_<level> and pr_fmt
      staging: bcm: Reindent source
      staging: bcm: Convert spaces to tabs
      staging: bcm: Cuddle braces
      staging: bcm: Add space after if/while/for/switch
      staging: bcm: for loop neatening
      staging: bcm: Remove trailing whitespace
      staging: bcm: Add space after comma
      staging: bcm: Convert USHORT to unsigned short
      staging: bcm: Convert typedef PUSHORT to unsigned short *
      staging: bcm: Convert typedef INT to int
      staging: bcm: Remove unused typedef PINT
      staging: bcm: Remove typedef CHAR, use char
      staging: bcm: Remove typedef PCHAR
      staging: bcm: Remove unused typedef SHORT
      staging: bcm: Remove unused typedef PSHORT
      staging: bcm: Convert typedef UCHAR to unsigned char
      staging: bcm: Convert typedef PUCHAR to unsigned char *
      staging: bcm: Convert typedef VOID to void
      staging: bcm: Convert typedef PVOID to void *
      staging: bcm: Convert typedef UINT to unsigned int
      staging: bcm: Convert typedef PUINT to unsigned int *
      staging: bcm: Convert typedef LONG to long
      staging: bcm: Remove unused typedef PLONG
      staging: bcm: Convert typedef ULONG to unsigned long
      staging: bcm: Convert typedef PULONG to unsigned long *
      staging: bcm: Convert typedef ULONG64 to unsigned long long
      staging: bcm: Convert typedef BUINT_8 to unsigned char
      staging: bcm: Convert typedef B_UINT16 to unsigned short
      staging: bcm: Convert typedef B_UINT32 to unsigned long
      staging: bcm: Convert define DWORD to unsigned int
      staging: bcm: Remove unused typedef DWORD
      staging: bcm: Convert typedef LARGE_INTEGER to unsigned long long
      staging: bcm: Convert typedef UINT32 to unsigned int
      staging: bcm: Remove spaces before semicolons

 drivers/staging/bcm/Adapter.h                  |  694 ++--
 drivers/staging/bcm/Bcmchar.c                  |  888 +++--
 drivers/staging/bcm/Bcmnet.c                   |   56 +-
 drivers/staging/bcm/CmHost.c                   | 2831 +++++++++------
 drivers/staging/bcm/CmHost.h                   |  176 +-
 drivers/staging/bcm/DDRInit.c                  | 2104 ++++++------
 drivers/staging/bcm/Debug.h                    |  189 +-
 drivers/staging/bcm/HandleControlPacket.c      |   87 +-
 drivers/staging/bcm/HostMIBSInterface.h        |  264 +-
 drivers/staging/bcm/IPv6Protocol.c             |  425 ++--
 drivers/staging/bcm/IPv6ProtocolHdr.h          |  107 +-
 drivers/staging/bcm/InterfaceAdapter.h         |   79 +-
 drivers/staging/bcm/InterfaceDld.c             |  136 +-
 drivers/staging/bcm/InterfaceIdleMode.c        |  283 +-
 drivers/staging/bcm/InterfaceIdleMode.h        |   11 +-
 drivers/staging/bcm/InterfaceInit.c            |  158 +-
 drivers/staging/bcm/InterfaceInit.h            |   19 +-
 drivers/staging/bcm/InterfaceIsr.c             |  201 +-
 drivers/staging/bcm/InterfaceIsr.h             |    7 +-
 drivers/staging/bcm/InterfaceMacros.h          |    2 +-
 drivers/staging/bcm/InterfaceMisc.c            |  109 +-
 drivers/staging/bcm/InterfaceMisc.h            |   48 +-
 drivers/staging/bcm/InterfaceRx.c              |  202 +-
 drivers/staging/bcm/InterfaceRx.h              |    1 -
 drivers/staging/bcm/InterfaceTx.c              |  152 +-
 drivers/staging/bcm/InterfaceTx.h              |    3 +-
 drivers/staging/bcm/Ioctl.h                    |  295 +-
 drivers/staging/bcm/LeakyBucket.c              |  386 +-
 drivers/staging/bcm/Macros.h                   |   10 +-
 drivers/staging/bcm/Misc.c                     |  895 +++--
 drivers/staging/bcm/PHSDefines.h               |   82 +-
 drivers/staging/bcm/PHSModule.c                | 1458 ++++----
 drivers/staging/bcm/PHSModule.h                |   40 +-
 drivers/staging/bcm/Protocol.h                 |   78 +-
 drivers/staging/bcm/Prototypes.h               |  194 +-
 drivers/staging/bcm/Qos.c                      |  965 +++---
 drivers/staging/bcm/Queue.h                    |   48 +-
 drivers/staging/bcm/Transmit.c                 |  218 +-
 drivers/staging/bcm/Typedefs.h                 |   32 +-
 drivers/staging/bcm/Version.h                  |    8 +-
 drivers/staging/bcm/cntrl_SignalingInterface.h |  370 +-
 drivers/staging/bcm/headers.h                  |    6 +-
 drivers/staging/bcm/hostmibs.c                 |   27 +-
 drivers/staging/bcm/led_control.c              |  472 ++--
 drivers/staging/bcm/led_control.h              |   73 +-
 drivers/staging/bcm/nvm.c                      | 4637 +++++++++++-------------
 drivers/staging/bcm/nvm.h                      |  234 +-
 drivers/staging/bcm/sort.c                     |   14 +-
 drivers/staging/bcm/target_params.h            |  109 +-
 drivers/staging/bcm/vendorspecificextn.c       |   25 +-
 drivers/staging/bcm/vendorspecificextn.h       |   20 +-
 51 files changed, 10121 insertions(+), 9807 deletions(-)





More information about the devel mailing list