[PATCH v2 5/6] staging:iio:events: Use non-atomic bitops

J.I. Cameron jic23 at cam.ac.uk
Thu Feb 2 14:15:57 UTC 2012


On Feb 2 2012, Dan Carpenter wrote:

>On Thu, Feb 02, 2012 at 02:19:16PM +0300, Dan Carpenter wrote:
>> On Thu, Feb 02, 2012 at 10:14:25AM +0100, Lars-Peter Clausen wrote:
>> > I don't think there is any real performance improvement to be expected of
>> > this patch. If you have good a reason why non-atomic bitops should not be
>> > used I guess this patch could be dropped.
>> 
>
>Actually perhaps it's better to apply this because the code is
>already tricky and the double underscores serve as a reminder.
>I'm fine with this change.
>
>Acked-by: Dan Carpenter <dan.carpenter at oracle.com>
>
>You could also remove the "/* Does anyone care? */ from
>iio_push_event() because we do care.
>
Ah, that one was my bad. Probably written way to late in the evening.
It  isn't meant to be a comment about the code, but rather a description
of what is being checked!  Literally 'This is checking whether there is anyone
listening'.

Jonathan



More information about the devel mailing list