[PATCH v2 5/6] staging:iio:events: Use non-atomic bitops

Dan Carpenter dan.carpenter at oracle.com
Thu Feb 2 11:49:22 UTC 2012


On Thu, Feb 02, 2012 at 02:19:16PM +0300, Dan Carpenter wrote:
> On Thu, Feb 02, 2012 at 10:14:25AM +0100, Lars-Peter Clausen wrote:
> > I don't think there is any real performance improvement to be expected of
> > this patch. If you have good a reason why non-atomic bitops should not be
> > used I guess this patch could be dropped.
> 

Actually perhaps it's better to apply this because the code is
already tricky and the double underscores serve as a reminder.
I'm fine with this change.

Acked-by: Dan Carpenter <dan.carpenter at oracle.com>

You could also remove the "/* Does anyone care? */ from
iio_push_event() because we do care.

regards,
dan carpenter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20120202/a11cbe11/attachment.asc>


More information about the devel mailing list