[PATCH 9/9] Staging: bcm: Fix warning: "Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ..."

Kevin McKinney klmckinney1 at gmail.com
Fri Dec 28 04:18:27 UTC 2012


This patch fixes the following warning: "WARNING:
Prefer netdev_dbg(netdev, ... then dev_dbg(dev,
... then pr_debug(...  to printk(KERN_DEBUG ..." in
Debug.h

Signed-off-by: Kevin McKinney <klmckinney1 at gmail.com>
---
 drivers/staging/bcm/Debug.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/bcm/Debug.h b/drivers/staging/bcm/Debug.h
index 03be63f..6d2bdd3 100644
--- a/drivers/staging/bcm/Debug.h
+++ b/drivers/staging/bcm/Debug.h
@@ -207,9 +207,9 @@ struct bcm_debug_state {
 			(Type & Adapter->stDebugState.type) &&		\
 			(SubType & Adapter->stDebugState.subtype[Type])) { \
 			if (dbg_level & DBG_NO_FUNC_PRINT)		\
-				printk(KERN_DEBUG string, ##args);	\
+				pr_debug("Message: %s\n", string);	\
 			else						\
-				printk(KERN_DEBUG "%s:" string, __func__, ##args); \
+				pr_debug("Function: %s, Message: %s\n", __func__, string); \
 		}							\
 	} while (0)
 
@@ -220,7 +220,7 @@ struct bcm_debug_state {
 				(dbg_level & DBG_LVL_BITMASK) <= Adapter->stDebugState.debug_level  && \
 				(Type & Adapter->stDebugState.type) &&	\
 				(SubType & Adapter->stDebugState.subtype[Type]))) { \
-			printk(KERN_DEBUG "%s:\n", __func__);		\
+			pr_debug("Function: %s\n", __func__);		\
 			print_hex_dump(KERN_DEBUG, " ", DUMP_PREFIX_OFFSET, \
 				16, 1, buffer, bufferlen, false);	\
 		}							\
-- 
1.7.9.5




More information about the devel mailing list