[PATCH 2/7] MFD:rtsx: Remove redundant code

Borislav Petkov bp at alien8.de
Mon Dec 24 10:11:34 UTC 2012


On Mon, Dec 24, 2012 at 02:03:24PM +0800, wei_wang at realsil.com.cn wrote:
> From: Wei WANG <wei_wang at realsil.com.cn>
> 
> Signed-off-by: Wei WANG <wei_wang at realsil.com.cn>
> ---
>  drivers/mfd/rtsx_pcr.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index 3a44efa..fa2c2bc 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -325,7 +325,6 @@ static void rtsx_pci_add_sg_tbl(struct rtsx_pcr *pcr,
>  	val = ((u64)addr << 32) | ((u64)len << 12) | option;
>  
>  	put_unaligned_le64(val, ptr);
> -	ptr++;
>  	pcr->sgi++;

Hmm, one has to look at the whole function to understand that the ptr++
statement is actually useless. A sentence or two as a the commit message
wouldn't hurt, IMHO.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--



More information about the devel mailing list