[PATCH] comedi: fix minimum AO period for NI 625x and NI 628x

Ian Abbott abbotti at mev.co.uk
Thu Dec 20 22:27:19 UTC 2012


On 20/12/12 14:09, Éric Piel wrote:
> On 19/12/12 17:43, Ian Abbott wrote:
>> Looks reasonable.  The AO speed checks were added to the NI drivers (in
>> the out-of-tree Comedi sources before they were imported into "staging")
>> in early May 2007 but probably weren't tested to the limits.
> Actually I've also used the git history from the out-of-tree sources,
> but mistook in how to use git blame!
> After looking at it again, the 357 value was introduced in 2005 in
> (commit 6d063feea3). At this time AO was not supported yet, so it was
> just commented out (which also means probably not tested). In 2007,
> commit 4a31ee5f added AO support for the driver and the value just got
> uncommented. It might not have been tested either at this time, as many
> other boards with different (and working) values were also available.
>
> So all in all, the version history doesn't say enough, but it could well
> be that maximum AO rate had never been tested on this board. Now it's
> done :-)
>
>> (I'll make the same change to the out-of-tree Comedi sources on
>> www.comedi.org.)
> Great! BTW, do I understand correctly that it's better to write patches
> for the staging tree, instead of the out-of-tree sources?

I'll take patches for either (or both) and port relevant bug fixes to 
the other (though I probably won't do anything to the out-of-tree 
sources until January now, as I've left my ssh keys at work).

> In any way, thanks for reviewing the patch Ian!

You're welcome!

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list