[PATCH 2/3] wlan-ng/prism2mgmt.c: formated too long lines

Dan Carpenter dan.carpenter at oracle.com
Mon Dec 17 14:08:51 UTC 2012


On Mon, Dec 17, 2012 at 02:38:02PM +0100, Sebastian Wankerl wrote:
> From: Sebastian Wankerl <sisewank at faui49man10.informatik.uni-erlangen.de>
> 

We allow long lines for string literals actually.  Or you can break
it up.

> Signed-off-by: Sebastian Wankerl <sisewank at cip.cs.fau.de> 
> Signed-off-by: Sebastian Ehrenfels <qi50dube at cip.cs.fau.de>
> 
> ---
>  drivers/staging/wlan-ng/prism2mgmt.c |   20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> index 62b94b0..4b3db73 100644
> --- a/drivers/staging/wlan-ng/prism2mgmt.c
> +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> @@ -1144,9 +1144,9 @@ int prism2mgmt_wlansniff(wlandevice_t *wlandev, void *msgp)
>  			/* Enable the port */
>  			result = hfa384x_drvr_enable(hw, 0);
>  			if (result) {
> -				pr_debug
> -				("failed to enable port to presniff setting, result=%d\n",
> -				     result);
> +				pr_debug(
> +					"failed to enable port to presniff setting,"
                                                                                   ^
Space needed.

You may as well put the string on the same line as the pr_debug().
It only costs you one char.

				pr_debug("failed to enable port for sniffing, "
					 "result = %d", result);

> +					"result=%d\n", result);
>  				goto failed;
>  			}

	[ snip ]

>  				/* Disable the port */
>  				result = hfa384x_drvr_disable(hw, 0);
>  				if (result) {
> -					pr_debug
> -					    ("failed to enable port for sniffing, result=%d\n",
> -					     result);
> +					pr_debug(
> +						"failed to enable port for "
                                                           ^^^^^^
Disable.

> +						"sniffing, result=%d\n",
> +						result);
>  					goto failed;
>  				}
>  			}

regards,
dan carpenter



More information about the devel mailing list