[PATCH 1/1] Drivers: hv: balloon: Fix a memory leak

Dan Carpenter dan.carpenter at oracle.com
Thu Dec 13 09:37:40 UTC 2012


On Tue, Dec 11, 2012 at 11:07:17AM -0800, K. Y. Srinivasan wrote:
> -probe_error1:
> +probe_error2:
>  	kthread_stop(dm_device.thread);
>  
> -probe_error0:
> +probe_error1:
>  	vmbus_close(dev->channel);
> +probe_error0:
> +	kfree(send_buffer);

If you used labels that describe what the code does instead of
GW-BASIC labels then you wouldn't need to rename them.

err_stop_thread:
	kthread_stop(dm_device.thread);
err_close_vmbus:
	vmbus_close(dev->channel);
err_free_send_buf:
	kfree(send_buffer);

regards,
dan carpenter




More information about the devel mailing list