[Line6linux-devel] [PATCH] staging: line6: pcm.c fix checkpatch issues

Laurent Navet laurent.navet at gmail.com
Wed Dec 12 12:39:30 UTC 2012


Ping ?

2012/11/30, Stefan Hajnoczi <stefanha at gmail.com>:
> Changes are fine.
>
> In the future, please split changes into individual patches.  For example:
> Patch 1 - Rename 'rv' to 'ret'
> Patch 2 - Replace decprecated simple_strtoul() with kstrtoint() in
> pcm_set_impulse_period()
> Patch 3 - Realign comment in line6_init_pcm() switch statement
>
> Keeping patches focussed on doing just one thing makes it easier to
> revert, bisect, and review them.
>
> Reviewed-by: Stefan Hajnoczi <stefanha at gmail.com>
>

Should I split patches as suggested by Stefan ?

Laurent.



More information about the devel mailing list