[PATCH 07/12] ipack/devices/ipoctal: avoid re-enable RX two times.
Samuel Iglesias Gonsalvez
siglesias at igalia.com
Mon Dec 10 10:50:03 UTC 2012
RX is enabled when the tty port is open, so no need to do it in initialization
time: it can allow the device to receive characters but no TTY client is
listening to them.
It produced an infinite number of IRQ as RxFIFO is not read to clear that
IRQ in the device, so it is still pending.
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
drivers/ipack/devices/ipoctal.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c
index 96467bb..45920f5 100644
@@ -60,6 +60,10 @@ static int ipoctal_port_activate(struct tty_port *port, struct tty_struct *tty)
channel = dev_get_drvdata(tty->dev);
+ * Enable RX. TX will be enabled when
+ * there is something to send
@@ -384,12 +388,6 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
- * Enable again the RX. TX will be enabled when
- * there is something to send
- iowrite8(CR_ENABLE_RX, &channel->regs->w.cr);
More information about the devel