[PATCH 02/12] ipack/devices/ipoctal: don't check if nb_bytes is < 0

Samuel Iglesias Gonsalvez siglesias at igalia.com
Mon Dec 10 10:49:58 UTC 2012


From: Alberto Garcia <agarcia at igalia.com>

It is an unsigned int so that check is pointless.

Signed-off-by: Alberto Garcia <agarcia at igalia.com>
Signed-off-by: Samuel Iglesias Gonsalvez <siglesias at igalia.com>
---
 drivers/ipack/devices/ipoctal.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/ipack/devices/ipoctal.c b/drivers/ipack/devices/ipoctal.c
index b312863..8f699b0 100644
--- a/drivers/ipack/devices/ipoctal.c
+++ b/drivers/ipack/devices/ipoctal.c
@@ -183,10 +183,8 @@ static void ipoctal_irq_tx(struct ipoctal_channel *channel)
 	unsigned char value;
 	unsigned int *pointer_write = &channel->pointer_write;
 
-	if (channel->nb_bytes <= 0) {
-		channel->nb_bytes = 0;
+	if (channel->nb_bytes == 0)
 		return;
-	}
 
 	value = channel->tty_port.xmit_buf[*pointer_write];
 	iowrite8(value, &channel->regs->w.thr);
-- 
1.7.10.4




More information about the devel mailing list