[PATCH] staging: rtl8712: avoid a useless call to memset().
dan.carpenter at oracle.com
Mon Dec 10 08:55:16 UTC 2012
On Sun, Dec 09, 2012 at 01:31:50AM +0100, Cyril Roelandt wrote:
> On 12/05/2012 08:11 AM, Dan Carpenter wrote:
> >On Wed, Dec 05, 2012 at 02:22:02AM +0100, Cyril Roelandt wrote:
> >>In r8711_wx_get_wap(), make sure we do not call memcpy() on a memory area that
> >>has just been zeroed by a call to memset().
> >I look at it like the original code is fine. Your version is also
> >fine but is it worth the churn? Also the curly braces are not
> Sorry about the braces.
> I just thought the code would be easier to understand this way, but
> it's probably OK to leave it as it currently is too.
Ah. I'd buy that. I like readability fixes. The indenting is also
messed up and confusing. It should be:
if (check_fwstate(pmlmepriv, _FW_LINKED | WIFI_ADHOC_MASTER_STATE |
memcpy(wrqu->ap_addr.sa_data, pcur_bss->MacAddress, ETH_ALEN);
memset(wrqu->ap_addr.sa_data, 0, ETH_ALEN);
More information about the devel