[PATCH] Staging: ft1000-usb: Fix call to obsolete function

Dan Carpenter dan.carpenter at oracle.com
Thu Dec 6 07:15:50 UTC 2012


On Wed, Dec 05, 2012 at 02:14:55PM -0500, devendra.aaru wrote:
> On Wed, Dec 5, 2012 at 2:03 PM, Kurt Kanzenbach <shifty91 at gmail.com> wrote:
> > strict_strtoul is obsolete and should be replaced with
> > kstrto* function as reported by checkpatch.pl.
> > pInfo->CardNumber is a u8. This is why kstrtou8 should be
> > used here.
> >
> > Signed-off-by: Kurt Kanzenbach <shifty91 at gmail.com>
> > ---
> >  drivers/staging/ft1000/ft1000-usb/ft1000_hw.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> > index 809fa48..6292ce1 100644
> > --- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> > +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> > @@ -702,7 +702,7 @@ int init_ft1000_netdev(struct ft1000_device *ft1000dev)
> >         int i, ret_val;
> >         struct list_head *cur, *tmp;
> >         char card_nr[2];
> > -       unsigned long gCardIndex = 0;
> > +       u8 gCardIndex = 0;
> it should be u32?

Kurt's code is ok.  It was explained in the changelog why he chose
u8.

regards,
dan carpenter




More information about the devel mailing list