[PATCH] Staging: ft1000-usb: Fix call to obsolete function
devendra.aaru
devendra.aaru at gmail.com
Wed Dec 5 19:14:55 UTC 2012
On Wed, Dec 5, 2012 at 2:03 PM, Kurt Kanzenbach <shifty91 at gmail.com> wrote:
> strict_strtoul is obsolete and should be replaced with
> kstrto* function as reported by checkpatch.pl.
> pInfo->CardNumber is a u8. This is why kstrtou8 should be
> used here.
>
> Signed-off-by: Kurt Kanzenbach <shifty91 at gmail.com>
> ---
> drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> index 809fa48..6292ce1 100644
> --- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> +++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
> @@ -702,7 +702,7 @@ int init_ft1000_netdev(struct ft1000_device *ft1000dev)
> int i, ret_val;
> struct list_head *cur, *tmp;
> char card_nr[2];
> - unsigned long gCardIndex = 0;
> + u8 gCardIndex = 0;
it should be u32?
>
> DEBUG("Enter init_ft1000_netdev...\n");
>
> @@ -723,7 +723,7 @@ int init_ft1000_netdev(struct ft1000_device *ft1000dev)
> if (strncmp(netdev->name, "eth", 3) == 0) {
> card_nr[0] = netdev->name[3];
> card_nr[1] = '\0';
> - ret_val = strict_strtoul(card_nr, 10, &gCardIndex);
> + ret_val = kstrtou8(card_nr, 10, &gCardIndex);
and this is kstrtoul?
> if (ret_val) {
> printk(KERN_ERR "Can't parse netdev\n");
> goto err_net;
> --
> 1.7.10.4
>
> _______________________________________________
> devel mailing list
> devel at linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
More information about the devel
mailing list