[PATCH] staging: comedi: pass through context for USB/PCI auto attach

Ian Abbott abbotti at mev.co.uk
Tue Dec 4 16:28:11 UTC 2012


On 2012-12-04 14:10, Dan Carpenter wrote:
> You guys have taken some unused code and made it more and more
> flexible.  I think you should just delete the parameter.  When you
> need a parameter, then we can add it back.  If you need two
> parameters then we can add two of them.

The one current driver that might have a use for it is the vmk80xx 
driver.  That one has `driver_info` values in its USB device table, but 
the driver currently uses that in its USB probe routine to allocate and 
initialize a load of stuff before it calls comedi_usb_auto_config().  If 
the driver was changed to remove the manual attachment functionality 
(the `attach` handler), I think all that stuff could be moved to the 
`auto_attach` handler, in which case setting the context parameter to 
the `driver_info` value would be useful.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-



More information about the devel mailing list