[PATCH] staging: comedi: rework the comedi_auto_config 'context'

Ian Abbott abbotti at mev.co.uk
Mon Dec 3 10:22:51 UTC 2012

On 2012-11-30 22:19, H Hartley Sweeten wrote:
> The 'context' passed to comedi_auto_config() is currently an unsigned
> long value. This value is passed to the (*auto_attach)() function of a
> comedi driver. Currently none of the comedi drivers use the 'context'.
> The only callers of comedi_auto_config() are the two inline wrappers
> comedi_pci_auto_config() and comedi_usb_auto_config(). Both of these
> pass a 'context' of 0.
> Change the 'context' to a const void * and rework the auto_config code
> and the pci/usb drivers so that the 'context' passed is the struct
> {pci,usb}_device_id * that is passed to the {pci,usb}_driver (*probe)()
> function.
> Signed-off-by: H Hartley Sweeten <hsweeten at visionengravers.com>
> Cc: Ian Abbott <abbotti at mev.co.uk>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

I'm not sure what you're planning to do with this, but maybe it would be 
better to pass the `driver_data` from the `struct pci_device_id` or the 
`driver_info` from the `struct usb_device_id` and change the type of the 
context to `kernel_ulong_t`?

-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti at mev.co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-

More information about the devel mailing list