[Suggestion] drivers/staging/telephony: strcpy and strcat, for structure members of PHONE_CID.

devendra.aaru devendra.aaru at gmail.com
Mon Dec 3 06:31:13 UTC 2012


On Mon, Dec 3, 2012 at 12:21 AM, Chen Gang <gang.chen at asianux.com> wrote:
> 于 2012年12月03日 13:12, devendra.aaru 写道:
>> Hi,
>>
>> On Sun, Dec 2, 2012 at 10:59 PM, Chen Gang <gang.chen at asianux.com> wrote:
>>> Hello Greg Kroah-Hartman
>>>
>>> in drivers/staging/telephony/ixj.c, for function ixj_write_cid:
>>
>> i think the telephony code has been deleted,
>>
>>
>
>   it seems not deleted, I find last commit of this file is Sep 19 2012.
>
>
> git log -p drivers/staging/telephony/ixj.c
>
> commit bff6c3e00ca7e56ca82e19ffb722159cf1216d20
> Author: Adam Buchbinder <adam.buchbinder at gmail.com>
> Date:   Wed Sep 19 21:51:08 2012 -0400
>
>     staging: Fix spelling of "asynchronous" in comments.
>
>     "Asychronous" is misspelled in some comments. No code changes.
>
>     Signed-off-by: Adam Buchbinder <adam.buchbinder at gmail.com>
>     Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>
> ...
>
>

i see a deletion with the next-20121127

commit 7326446c728f633a0d6b3318cf491f71f044dce0
Author: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
Date:   Fri Oct 26 13:06:04 2012 -0700

    Staging: remove telephony drivers

    We said we would wait until the 3.6 kernel release to remove these
    drivers.  So we waited 6 months longer, that should be fine.

    If anyone wants them back, it is trivial to revert these, but given that
    I don't think they even build anymore, I doubt anyone will want them.

    Cc: Joe Perches <joe at perches.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>


are we not seeing common trees? :-)



More information about the devel mailing list