[PATCH 09/20] staging: comedi: adv_pci1723: fix initial dio subdevice state and io_bits

Dan Carpenter dan.carpenter at oracle.com
Mon Aug 20 21:49:17 UTC 2012


On Fri, Aug 17, 2012 at 06:17:38PM -0700, H Hartley Sweeten wrote:
> +	if (this_board->n_diochan) {
> +		s = dev->subdevices + subdev;

This pointer math sucks still...  I feel like the unreadable code is
part of what caused this bug.

We don't have to change these all at once.  If we fix only one line,
then at least one line will be readable and that is one more than
before so *improvement*.

regards,
dan carpenter




More information about the devel mailing list