[PATCH] staging: media: cxd2099: remove memcpy of similar structure variables

Ezequiel Garcia elezegarcia at gmail.com
Sun Aug 5 21:51:45 UTC 2012


Hi Devendra,

Thanks for the patch,

On Sun, Aug 5, 2012 at 5:40 PM, Devendra Naga
<develkernel412222 at gmail.com> wrote:
> structure variables can be assigned, no memcpy needed,
> remove the memcpy and use assignment for the cfg and en variables.
>
> Tested by Compilation Only
>
> Suggested-by: Ezequiel Garcia <elezegarcia at gmail.com>

I'm not sure this is completely valid or useful.

If you read Documentation/SubmittingPatches (which you should)
you will find references to Acked-by, Reported-by, Tested-by,
but not this one.

You don't need to give me credit for the patch:
it's *your* patch, all I did was a very simple suggestion :-)

Plus, there was some discussion called "Kernel Komedians" [1] where
some developer expressed their concern on the number of weird signatures
that have recently appeared.

Regards,
Ezequiel.

[1] http://lwn.net/Articles/503829/



More information about the devel mailing list