[stable 2.6.36+] lirc_sir: make device registration work

Stefan Lippers-Hollmann s.L-H at gmx.de
Wed Aug 1 13:51:09 UTC 2012


Hi

Please consider adding "[media] lirc_sir: make device registration 
work" to stable:

<formletter>

This probably needs to get acked by the subsystem maintainer.

</formletter>

commit 4b71ca6bce8fab3d08c61bf330e781f957934ae1
Author: Jarod Wilson <jarod at redhat.com>
Date:   Mon Jun 4 13:05:24 2012 -0300

    [media] lirc_sir: make device registration work
    
    For one, the driver device pointer needs to be filled in, or the lirc core
    will refuse to load the driver. And we really need to wire up all the
    platform_device bits. This has been tested via the lirc sourceforge tree
    and verified to work, been sitting there for months, finally getting
    around to sending it. :\
    
    CC: Josh Boyer <jwboyer at redhat.com>
    Signed-off-by: Jarod Wilson <jarod at redhat.com>
    Signed-off-by: Mauro Carvalho Chehab <mchehab at redhat.com>

[backporting to <= v3.1, needed for 3.0-longterm]
The lirc subdirectory moved from drivers/staging/lirc/ to 
drivers/staging/media/lirc/ in kernel v3.2, for older kernels this
can simply be backported with:

	sed -i 's|drivers/staging/media/lirc/|drivers/staging/lirc/|g' media-lirc_sir-make-device-registration-work.patch

no other changes are required for v3.0-longterm, build-tested.


This commit fixes loading the lirc_sir module, which previously 
wouldn't load/ be usable at all (since its introduction in v2.6.36).

serial8250: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
smsc_superio_flat(): fir: 0x230, sir: 0x2f8, dma: 03, irq: 3, mode: 0x0e
smsc_ircc_present: can't get sir_base of 0x2f8
[…]
lirc_dev: IR Remote Control driver registered, major 251
lirc_sir: module is from the staging directory, the quality is unknown, you have been warned.
lirc_register_driver: dev pointer not filled in!
lirc_sir: init_chrdev() failed.

The afforementioned commit fixes this problem and makes lirc_sir 
usable:

serial8250: ttyS1 at I/O 0x2f8 (irq = 3) is a 16550A
smsc_superio_flat(): fir: 0x230, sir: 0x2f8, dma: 03, irq: 3, mode: 0x0e
smsc_ircc_present: can't get sir_base of 0x2f8
[…]
lirc_dev: IR Remote Control driver registered, major 251 
lirc_sir: module is from the staging directory, the quality is unknown, you have been warned.
platform lirc_dev.0: lirc_dev: driver lirc_sir registered at minor = 0
lirc_sir: I/O port 0x02f8, IRQ 3.
lirc_sir: Installed

Without this patch lirc_sir can't even get loaded, the alternative 
would be to mark it as BROKEN for <<3.6.

Bug references:
- RedHat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=557210 [2.6.31.9-174.fc12.i686.PAE]
- Ubuntu launchpad: https://bugs.launchpad.net/ubuntu/+source/lirc/+bug/912251 [3.0.0-12-generic]
- Debian BTS: http://bugs.debian.org/680762 [3.2+]

Regards
	Stefan Lippers-Hollmann



More information about the devel mailing list