[PATCHi V2] staging: r8192e_pci: Change memcpy to memcmp
Larry Finger
Larry.Finger at lwfinger.net
Fri Apr 20 19:45:37 UTC 2012
Routine rtllib_MlmeDisassociateRequest() has a comparison of memcpy()
with NULL, which makes no sense. Analysis of the code suggests that
memcmp() was intended.
Reported-by: Dan Carpenter <dan.carpenter at oracle.com>
Signed-off-by: Larry Finger <Larry.Finger at lwfinger.net>
---
V2 - Fix compiler warning
---
Greg,
This routine has never been entered in all my testing of this driver,
thus this patch has no particular priority.
Thanks,
Larry
---
drivers/staging/rtl8192e/rtllib_softmac.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index c5a15db..703fa84 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -3679,8 +3679,7 @@ void rtllib_MlmeDisassociateRequest(struct rtllib_device *rtllib, u8 *asSta,
RemovePeerTS(rtllib, asSta);
-
- if (memcpy(rtllib->current_network.bssid, asSta, 6) == NULL) {
+ if (memcmp(rtllib->current_network.bssid, asSta, 6) == 0) {
rtllib->state = RTLLIB_NOLINK;
for (i = 0; i < 6; i++)
--
1.7.10.130.g36e6c
More information about the devel
mailing list