[PATCH] zcache: Use WARN_ON_SMP in ASSERT_SPINLOCK

Greg Kroah-Hartman gregkh at linuxfoundation.org
Tue Apr 10 16:04:58 UTC 2012


On Sun, Mar 11, 2012 at 10:00:54PM +0100, Jörg Sommer wrote:
> As the description of WARN_ON_SMP in bug.h says, one can not use
> spin_is_locked() in assertions for non‐SMP configurations, because it
> always returns the lock is not held. Otherwise a warning is thrown
> everytime on a uniprocessor system.
> ---
>  drivers/staging/zcache/tmem.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

I can't take this patch, as there is no Signed-off-by line :(

Please read Documentation/SubmittingPatches and resend it after doing
what that file asks.

Also, please don't send base64 messages :(

Care to redo it, and resend, with Dan's ack so that I can apply it?

thanks,

greg k-h



More information about the devel mailing list