[PATCH 14/20] staging: brcm80211: remove dongle firmware related debug code

Johannes Berg johannes at sipsolutions.net
Sat Sep 24 10:39:45 UTC 2011


On Fri, 2011-09-23 at 19:09 -0700, Franky Lin wrote:
> From: Arend van Spriel <arend at broadcom.com>
> 
> When the device dies the driver could extract cpu registers on
> the device to analyze the trap handling on the dongle. As the
> firmware with this driver is stable this code does not belong
> in the brcmfmac driver.
> 
> Reported-by: Johannes Berg <johannes at sipsolutions.net>

FWIW, when I said this looked strange I might have thought that it was
actually accessing the *host* registers. I don't remember exactly what I
said. If this is debug code for the dongle, then maybe it makes sense to
keep it, maybe optionally. I don't think you'll want to support a
separate driver just for debug. You could even use nl80211 testmode to
export it to userspace for your tools.

johannes




More information about the devel mailing list