[PATCH 20/20] staging: brcm80211: reduced checkpatch warnings to zero

Franky Lin frankyl at broadcom.com
Tue Sep 20 01:04:13 UTC 2011


On 09/19/2011 05:04 PM, Joe Perches wrote:
> Splitting format strings is poor style, makes
> error messages difficult to find via grep and
> is error prone.
>
> You should update your checkpatch version.
> Current checkpatch doesn't warn about this.

Thank you for pointing this out.

> It'd be better if you could find some way
> to reduce the 6 tab indentation rather than
> split 20 char format strings into pieces.

Greg, could you please drop this one? We will take care of the 
indentation issue in future patches.

Thanks,
Franky




More information about the devel mailing list