[PATCH v2] Move brcm80211 to mainline

Rafał Miłecki zajec5 at gmail.com
Sat Sep 10 16:48:38 UTC 2011


Henry, you ignored most of the questions and explanations. In this
situation I don't have anything more to add, I'll just post few
comments/updates.

W dniu 30 sierpnia 2011 08:17 użytkownik Rafał Miłecki
<zajec5 at gmail.com> napisał:
> 2011/8/30 Henry Ptasinski <henryp at broadcom.com>:
>> The b43 driver doesn't implement transmit power control for the BCM43224 or
>> BCM43225, and has various other unimplemented phy functions, e.g.:
>>
>>> void b43_nphy_set_rxantenna(struct b43_wldev *dev, int antenna)
>>> {//TODO
>>> }
>>>
>>> static void b43_nphy_op_adjust_txpower(struct b43_wldev *dev)
>>> {//TODO
>>> }
>>>
>>> static enum b43_txpwr_result b43_nphy_op_recalc_txpower(struct b43_wldev *dev,
>>>                                                         bool ignore_tssi)
>>> {//TODO
>>>         return B43_TXPWR_RES_DONE;
>>> }
>>>
>>> ...
>>>       b43err(dev->wl, "enabling tx pwr ctrl not implemented yet\n"); ...
>>> ...
>>
>> etc.
>
> I've just checked your wlc_phy_txpower_recalc_target_nphy. It's calling:
> 1) Trivial wlc_phy_txpwr_limit_to_tbl_nphy
> 2) More advanced wlc_phy_txpwrctrl_pwr_setup_nphy we have to implement
> 3) Already-implemented-in-b43 wlapi_bmac_mctrl
> 4) 50% implemented wlc_phy_txpwrctrl_enable_nphy
>
> I can do this in 1 day.

If you watch linux-wireless ML, you could see I've started
implementing calibration for N-PHY in b43.

A progress is little slower recently because of:
1) Me having less time in few recent days
2) Problems with kernel.org servers

In any case, *I'm going to finish N-PHY calibration* in b43. I've more
stuff already, just need to test it before posting and make sure
nothing was missed due to problems with git.kernel.org.

I've also finished initialization of static tables for LCN-PHY and
implemented basic operations. Now I'm just going to rewrite other
initialization ops and that should give us working LCN support.

I'm moving to the new place in next week (that's why I've been busy
recently) and will start playing with 5 GHz support in b43.


Too bad you didn't respond to all our questions and comments :| Ppl
started commenting that [0] without seeing the real solution I wanted
to see discussed with you.

[0] http://www.h-online.com/open/features/Kernel-comment-The-obstacle-course-of-cooperation-1340020.html

-- 
Rafał



More information about the devel mailing list