[PATCH v2 19/21] staging: r8712u: Merging Realtek's latest (v2.6.6). Tx aggregation.

Ali Bahar ali at internetdog.org
Sat Sep 10 05:33:55 UTC 2011


Hi Dan,


On Fri, Sep 09, 2011 at 10:26:26PM -0700, Dan Carpenter wrote:
> On Sun, Sep 04, 2011 at 03:14:22AM +0800, Ali Bahar wrote:
> > Tx Aggregation (CONFIG_R8712_TX_AGGR, known as CONFIG_USB_TX_AGGR in the
> > Realtek tarball) is now added.
> > 
> > However, its tests have not been successful! The default in the Realtek
> > tarball is to not build it -- and the Release Notes does not seem to list this
> > as a feature. I have tested the driver with and without this feature; the
> > former does not successfully associate when WPA2 is used.
> > 
> 
> Probably we shouldn't include it if it's broken?

Larry suggested adding a BROKEN to its Kconfig. So it then got:
  depends on R8712U && BROKEN


> 
> I dropped my netbook and corrupted my git archive (grr...) so I

I was wondering where you were! :-)
Sorry about the notebook.


> haven't totally reviewed this patchset, but it's a million times
> improved from v1.  Thank you for doing this work.

You're welcome. Thank you and Larry for your help & reviews. 

regards,
ali


 
> regards,
> dan carpenter
> 



More information about the devel mailing list